Skip to content

BUG: CoW - correctly track references for chained operations #48996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 1, 2022
Merged

BUG: CoW - correctly track references for chained operations #48996

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
12c9a54
BUG: CoW - correctly track references for chained operations
jorisvandenbossche Oct 7, 2022
0518dda
fix typo
jorisvandenbossche Oct 10, 2022
1996d82
try fixing typing errors
jorisvandenbossche Oct 10, 2022
8026893
add test with long chain and mixed loc/iloc
jorisvandenbossche Oct 13, 2022
e686ad5
Merge branch 'main' into pr/48996
phofl Oct 14, 2022
8f5c965
Fix typing
phofl Oct 17, 2022
597ed0f
Merge remote-tracking branch 'upstream/main' into cow-fix-chaining
jorisvandenbossche Oct 28, 2022
3738b57
clear parent if no refs left
jorisvandenbossche Oct 28, 2022
6700ced
adds whatsnew
jorisvandenbossche Oct 28, 2022
eab97f0
cover mgr._combine through select_dtypes
jorisvandenbossche Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Oct 10, 2022
commit 0518ddacbf87bc1b090a9ba500764b93ca289801
2 changes: 1 addition & 1 deletion pandas/core/internals/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2050,7 +2050,7 @@ def get_slice(self, slobj: slice, axis: AxisInt = 0) -> SingleBlockManager:
new_index = self.index._getitem_slice(slobj)
# TODO this method is only used in groupby SeriesSplitter at the moment,
# so passing refs / parent is not yet covered by the tests
return type(self)(block, new_index[weakref.ref(blk)], parent=self)
return type(self)(block, new_index, [weakref.ref(blk)], parent=self)

@property
def index(self) -> Index:
Expand Down