Skip to content

ENH: add na_action to Categorical.map & CategoricalIndex.map #51645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 30, 2023
Merged

ENH: add na_action to Categorical.map & CategoricalIndex.map #51645

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6e62b26
ENH: add na_action to Categorical.map
topper-123 Feb 24, 2023
7672271
add GH numbers
topper-123 Feb 26, 2023
1c5b392
pre-commit issues
topper-123 Mar 4, 2023
5b07029
map Categorical with Series
topper-123 Mar 6, 2023
85b4193
REF: simplify .map
topper-123 Mar 6, 2023
6dfdf87
pass test_map
topper-123 Mar 13, 2023
ed6b1d7
fix whatsnew
topper-123 Mar 14, 2023
2018aaf
cleanups
topper-123 Mar 18, 2023
84beb35
pre-commit
topper-123 Mar 18, 2023
01b199d
deprecate Categorical.map(na_action=ignore)
topper-123 Mar 19, 2023
7e470c9
fix docstrings
topper-123 Mar 19, 2023
afb843b
fix rebase
topper-123 Mar 22, 2023
ef5ed65
simplity implementation
topper-123 Mar 24, 2023
be2d451
fix warn
topper-123 Mar 29, 2023
9d0c325
fix comments
topper-123 Mar 30, 2023
8cae085
Merge branch 'master' into categorical_map_na_Action
topper-123 Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pass test_map
  • Loading branch information
@topper-123
topper-123 committed Mar 29, 2023
commit 6dfdf878c5d723bff812091f1a74b19382b832fd
8 changes: 2 additions & 6 deletions pandas/tests/extension/test_categorical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,12 +186,8 @@ def test_combine_add(self, data_repeated):

@pytest.mark.parametrize("na_action", [None, "ignore"])
def test_map(self, data, na_action):
if na_action is not None:
with pytest.raises(NotImplementedError, match=""):
data.map(lambda x: x, na_action=na_action)
else:
result = data.map(lambda x: x, na_action=na_action)
self.assert_extension_array_equal(result, data)
result = data.map(lambda x: x, na_action=na_action)
self.assert_extension_array_equal(result, data)


class TestCasting(base.BaseCastingTests):
Expand Down