Skip to content

BUG: Fix return type of loc/iloc #61054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 30, 2025
Merged

BUG: Fix return type of loc/iloc #61054

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5003eaa
Fix loc dtype
sanggon6107 Mar 4, 2025
d4a031b
Modify test_loc_setitem_frame_mixed_labels accordingly
sanggon6107 Mar 4, 2025
2536652
Add test for the linked issue
sanggon6107 Mar 4, 2025
c5a5de1
Fix test_loc_dtype
sanggon6107 Mar 4, 2025
1f529ce
Fix dtype inference
sanggon6107 Mar 6, 2025
ec9fd4f
Merge branch 'main' of https://github.com/sanggon6107/pandas into fix…
sanggon6107 Mar 13, 2025
d2e29c0
Reverse tuple to avoid unintended dtype inference
sanggon6107 Mar 13, 2025
74eb356
Reverse axis order
sanggon6107 Mar 17, 2025
8677f0d
Merge branch 'main' into fix-loc-dtype
sanggon6107 Mar 31, 2025
6388d93
Reverse indexing order
sanggon6107 Apr 2, 2025
319d717
Merge branch 'main' into fix-loc-dtype
sanggon6107 Apr 17, 2025
3596f76
Explicitly assign the expected result
sanggon6107 Apr 17, 2025
190e1e4
Merge branch 'main' into fix-loc-dtype
sanggon6107 May 13, 2025
502fa47
Merge branch 'main' into fix-loc-dtype
sanggon6107 Jun 3, 2025
939237c
Merge branch 'main' into fix-loc-dtype
sanggon6107 Jun 4, 2025
5af6c7f
Add whatsnew
sanggon6107 Jun 9, 2025
461b4cb
Merge branch 'main' into fix-loc-dtype
sanggon6107 Jun 10, 2025
08111d3
Merge branch 'main' into fix-loc-dtype
sanggon6107 Jun 10, 2025
f73b518
Merge branch 'main' into fix-loc-dtype
sanggon6107 Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test_loc_dtype
  • Loading branch information
@sanggon6107
sanggon6107 committed Mar 4, 2025
commit c5a5de160728684a3583a2afb3e8bc64ab8e7bde
2 changes: 1 addition & 1 deletion pandas/tests/indexing/test_loc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def test_loc_dtype():
df = DataFrame([["a", 1.0, 2.0], ["b", 3.0, 4.0]])
result = df.loc[0, [1, 2]]
expected = df[[1, 2]].loc[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide expected explicitly here: expected = DataFrame(...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the code change. Thanks for the suggestion!

tm.assert_frame_equal(result, expected)
tm.assert_series_equal(result, expected)


class TestLoc:
Expand Down
Loading