Skip to content

Created new Fortanix KMIP topic for TDE #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: TDE_REL_17_STABLE
Choose a base branch
from

Conversation

Andriciuc
Copy link
Collaborator

Since we can use Fortanix, I added it to the config KMIP section, it tells the user where to look for more details on setting it up and provides a bit of examples with pg_tde_add_global_key_provider_kmip

Since we can use Fortanix, I added it to the config KMIP section, it tells the user where to look for more details on setting it up and provides a bit of examples with pg_tde_add_global_key_provider_kmip
Andriciuc and others added 3 commits May 28, 2025 12:32
updated the SELECT example with clarification and updated the link for the KMIP (generic client install)

Added a note to reinforce the region requirement
updated setup step 1 from recommended steps
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.48%. Comparing base (4575c03) to head (255cd4a).

❌ Your project status has failed because the head coverage (85.48%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                Coverage Diff                 @@
##           TDE_REL_17_STABLE     #368   +/-   ##
==================================================
  Coverage              85.48%   85.48%           
==================================================
  Files                     22       22           
  Lines                   2536     2536           
  Branches                 387      387           
==================================================
  Hits                    2168     2168           
  Misses                   294      294           
  Partials                  74       74           
Components Coverage Δ
access 84.20% <ø> (ø)
catalog 88.59% <ø> (ø)
common 91.80% <ø> (ø)
encryption 72.56% <ø> (ø)
keyring 72.42% <ø> (ø)
src 91.42% <ø> (ø)
smgr 97.41% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

improved steps, still would like each step to be more descriptive though
@nastena1606 nastena1606 temporarily deployed to docs-add-fortanix - INTERNAL-pg_tde docs PR #368 June 3, 2025 07:47 — with Render Destroyed
@nastena1606 nastena1606 temporarily deployed to docs-add-fortanix - pg-tde-docs PR #368 June 3, 2025 07:47 — with Render Destroyed
Andriciuc and others added 3 commits June 5, 2025 12:06
removed recommended config steps and I pointed the user to the Adding or modifying KMIP providers topic for examples of config files
@nastena1606 nastena1606 temporarily deployed to docs-add-fortanix - pg-tde-docs PR #368 June 5, 2025 09:09 — with Render Destroyed
@nastena1606 nastena1606 temporarily deployed to docs-add-fortanix - INTERNAL-pg_tde docs PR #368 June 5, 2025 09:09 — with Render Destroyed
removed example config title
removed out of date notes, not needed as we don't explain config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants