forked from postgres/postgres
-
Notifications
You must be signed in to change notification settings - Fork 9
Created new Fortanix KMIP topic for TDE #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andriciuc
wants to merge
20
commits into
TDE_REL_17_STABLE
Choose a base branch
from
docs-add-fortanix
base: TDE_REL_17_STABLE
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can use Fortanix, I added it to the config KMIP section, it tells the user where to look for more details on setting it up and provides a bit of examples with pg_tde_add_global_key_provider_kmip
dutow
reviewed
May 27, 2025
contrib/pg_tde/documentation/docs/global-key-provider-configuration/kmip-fortanix.md
Outdated
Show resolved
Hide resolved
contrib/pg_tde/documentation/docs/global-key-provider-configuration/kmip-fortanix.md
Outdated
Show resolved
Hide resolved
contrib/pg_tde/documentation/docs/global-key-provider-configuration/kmip-fortanix.md
Outdated
Show resolved
Hide resolved
updated the SELECT example with clarification and updated the link for the KMIP (generic client install) Added a note to reinforce the region requirement
updated setup step 1 from recommended steps
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.48%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #368 +/- ##
==================================================
Coverage 85.48% 85.48%
==================================================
Files 22 22
Lines 2536 2536
Branches 387 387
==================================================
Hits 2168 2168
Misses 294 294
Partials 74 74
🚀 New features to boost your workflow:
|
improved steps, still would like each step to be more descriptive though
dutow
reviewed
Jun 4, 2025
contrib/pg_tde/documentation/docs/global-key-provider-configuration/kmip-fortanix.md
Outdated
Show resolved
Hide resolved
contrib/pg_tde/documentation/docs/global-key-provider-configuration/kmip-fortanix.md
Outdated
Show resolved
Hide resolved
removed recommended config steps and I pointed the user to the Adding or modifying KMIP providers topic for examples of config files
removed example config title
dutow
reviewed
Jun 6, 2025
contrib/pg_tde/documentation/docs/global-key-provider-configuration/kmip-fortanix.md
Outdated
Show resolved
Hide resolved
removed out of date notes, not needed as we don't explain config
dutow
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can use Fortanix, I added it to the config KMIP section, it tells the user where to look for more details on setting it up and provides a bit of examples with pg_tde_add_global_key_provider_kmip