Skip to content

Added a snippet for serving WebP images #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2015
Merged

Added a snippet for serving WebP images #30

merged 2 commits into from
Feb 23, 2015

Conversation

vincentorback
Copy link
Contributor

As the title states ⬆️
Source.

@phanan
Copy link
Owner

phanan commented Feb 18, 2015

Great. Could you do update the PR with these:

  • Remove the IfModule directive, as its implication has been introduced
  • Make the section title, well, title-cased (I'll ask for this explictly in CONTRIBUTING.md in the next commit), and
  • Give a hint that this technique can be used for other file types as well, because this is a great chance to do so.

Thanks!

@phanan phanan merged commit c549272 into phanan:master Feb 23, 2015
@phanan
Copy link
Owner

phanan commented Feb 23, 2015

Nevermind, I've gone ahead and modified your version a bit. Thanks!

@vincentorback
Copy link
Contributor Author

Awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentorback @phanan