Skip to content

Fix #523 Incorrect PHP reflection type for Memcached::cas $cas_token #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

remicollet
Copy link
Collaborator

No description provided.

@remicollet
Copy link
Collaborator Author

After a bit more thinking, seems better to use proper type hinting

Reflection diff:

@@ -413,7 +413,7 @@
         Method [ <internal:memcached> public method cas ] {
 
           - Parameters [4] {
-            Parameter #0 [ <required> string $cas_token ]
+            Parameter #0 [ <required> string|int|float $cas_token ]
             Parameter #1 [ <required> string $key ]
             Parameter #2 [ <required> mixed $value ]
             Parameter #3 [ <optional> int $expiration = 0 ]
@@ -424,7 +424,7 @@
         Method [ <internal:memcached> public method casByKey ] {
 
           - Parameters [5] {
-            Parameter #0 [ <required> string $cas_token ]
+            Parameter #0 [ <required> string|int|float $cas_token ]
             Parameter #1 [ <required> string $server_key ]
             Parameter #2 [ <required> string $key ]
             Parameter #3 [ <required> mixed $value ]

Copy link
Collaborator

@sodabrew sodabrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@remicollet
Copy link
Collaborator Author

Squashed and merged

@remicollet remicollet closed this Nov 16, 2022
@remicollet remicollet deleted the issue-523 branch November 16, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants