Skip to content

Fix unused variable in pdo_sqlite_stmt_set_attribute() #18851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iluuu1994 merged 1 commit into from
Jun 14, 2025
Merged

Fix unused variable in pdo_sqlite_stmt_set_attribute() #18851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix unused variable in pdo_sqlite_stmt_set_attribute() 
The indentation is also wrong (using spaces instead of tabs), but this should be
fixed in a separate commit.
  • Loading branch information
@iluuu1994
iluuu1994 committed Jun 14, 2025
commit d25ad9691008cb9967f645e9dc0054844fffd6a5
4 changes: 2 additions & 2 deletions ext/pdo_sqlite/sqlite_statement.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,6 @@ static int pdo_sqlite_stmt_get_attribute(pdo_stmt_t *stmt, zend_long attr, zval

static int pdo_sqlite_stmt_set_attribute(pdo_stmt_t *stmt, zend_long attr, zval *zval)
{
pdo_sqlite_stmt *S = (pdo_sqlite_stmt*)stmt->driver_data;

switch (attr) {
case PDO_SQLITE_ATTR_EXPLAIN_STATEMENT:
#if SQLITE_VERSION_NUMBER >= 3041000
Expand All @@ -434,6 +432,8 @@ static int pdo_sqlite_stmt_set_attribute(pdo_stmt_t *stmt, zend_long attr, zval
zend_value_error("explain mode must be one of the Pdo\\Sqlite::EXPLAIN_MODE_* constants");
return 0;
}

pdo_sqlite_stmt *S = (pdo_sqlite_stmt*)stmt->driver_data;
Copy link
Member

@TimWolla TimWolla Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cast is also not necessary here.

Suggested change
pdo_sqlite_stmt *S = (pdo_sqlite_stmt*)stmt->driver_data;
pdo_sqlite_stmt *S = stmt->driver_data;

Copy link
Member Author

@iluuu1994 iluuu1994 Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically not, but casting void* is somewhat of a personal preference. It's there for all other usages of driver_data in this file, so we should probably stay consistent.

if (sqlite3_stmt_explain(S->stmt, (int)Z_LVAL_P(zval)) != SQLITE_OK) {
return 0;
}
Expand Down