fix(freehand&i18n): fix i18n of freehand toolbar and make secondary toolbar always exist while using freehand element #255
Conversation
|
Very cool @NaoCoding ! I can preview the deploy page https://fix-freehand.drawnix.pages.dev now, that's very convenient.
|
|
Let me fix the selected hover stuff |
| const getCurrentFreehandIcon = () => { | ||
| const currentPointer = board.pointer; | ||
| if (currentPointer === FreehandShape.eraser) { | ||
| const getFreehandIcon = (pointer) => { |
There was a problem hiding this comment.
is the function getFreehandIcon useless?
There was a problem hiding this comment.
Yes, it is useless. I forgot to delete this function after refactor the logic of the freehand toolbar
Deploying drawnix with
|
| Latest commit: |
230d496
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://31470ebb.drawnix.pages.dev |
| Branch Preview URL: | https://fix-freehand.drawnix.pages.dev |
|
Hi @pubuzhixing8 , I have resolved all the issues. |
|
I have another suggestion about previous pr which the file name of |
|
Sure, I think the suggestion provide a better readability and more affordable for further maintenance. Let me modify the file name. |
|
@pubuzhixing8 Done! |
|
The new experience is great 👍🏻! |
Fix all the follow-up issus mentioned in #247
Freehand tool selection and toolbar improvements:
CreationToolbarto track and display the last selected freehand tool, ensuring the toolbar button always shows the user's most recent choice. [1] [2]i18n: