feat: add stroke select state, add stroke type text #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
WBbug
commented
Aug 31, 2025
- add stroke select state
- add stroke type text
Contributor
|
LGTM, thank @WBbug ! If you have time you could review it again @NaoCoding . |
Member
|
Hi @pubuzhixing8 , |
NaoCoding
requested changes
Sep 1, 2025
Member
NaoCoding
left a comment
There was a problem hiding this comment.
Hello, it seems that the selected states aren't set properly. When the stroke style changed, the selected states will not changed to the target style.
Member
|
The selected status should change the background color of the |
NaoCoding
reviewed
Sep 1, 2025
Deploying drawnix with
|
| Latest commit: |
b328d44
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c8e35e64.drawnix.pages.dev |
| Branch Preview URL: | https://optimize-stroke-text.drawnix.pages.dev |
NaoCoding
approved these changes
Sep 1, 2025
Member
NaoCoding
left a comment
There was a problem hiding this comment.
LGTM! Maybe @pubuzhixing8 you can check for the last time.
Contributor
|
Great @WBbug @NaoCoding , I will merge then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.