Skip to content

Conversation

@pubuzhixing8
Copy link
Contributor

@pubuzhixing8 pubuzhixing8 commented Sep 3, 2025

This pull request will bump plait packages into 0.85.0 that both width and height properties in mind element were removed in this version(adding dynamic calculating logic in 0.84.0) and rename mind type value to mind and set type as mind_child for other children elements.

refer to prs: worktile/plait#1077, worktile/plait#1078, worktile/plait#1079

  1. bump markdown-to-drawnix which bumped plait and remove width-height dynamic calculating logic
  2. remove both useless width and height for mind elements on example data.

This pull request will bump plait packages into 0.85.0 that both width and height properties in mind element in this version, add dynamic calculating logic and rename mind type value to `mind` and set type as `mind_child` for other mind elements worktile/plait#1077
1. bump `markdown-to-drawnix` which bumped plait and remove width-height dynamic calculating logic
2. remove both useless width and height for mind elements on example data.
@pubuzhixing8
Copy link
Contributor Author

pubuzhixing8 commented Sep 3, 2025

Hi @NaoCoding, please help to review.

We do not need width and height in mind data now, it will help to resolve compatible issue metioned in #208.

The calculating performance is fine (1000 times only cost 3-5ms).

Copy link
Member

@NaoCoding NaoCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't see there's any issues after bump the version.

@pubuzhixing8 pubuzhixing8 merged commit fb293df into develop Sep 3, 2025
2 checks passed
@pubuzhixing8 pubuzhixing8 deleted the bump-plait-0.85.0 branch September 3, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants