feat(eraser): drawing erasing effect #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to drawing laser effect This pull request will implement eraser trail animation effect mentioned in #247
Deploying drawnix with
|
| Latest commit: |
3c10174
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dd06695e.drawnix.pages.dev |
| Branch Preview URL: | https://laser-pointer.drawnix.pages.dev |
Contributor
Author
|
Hi @NaoCoding, I finished the feature, please help me review. |
NaoCoding
reviewed
Sep 11, 2025
NaoCoding
approved these changes
Sep 11, 2025
Member
NaoCoding
left a comment
There was a problem hiding this comment.
Generally LGTM, just a small part I think maybe we can improve? Or actually there may be some cases and usage in the future.
NaoCoding
reviewed
Sep 11, 2025
Contributor
Author
|
@NaoCoding Done!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will implement eraser trail animation effect mentioned in #247.