bug fixes #12
Merged
bug fixes #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling ad6284f on thehobbit85:master into ** on pocesar:master**. |
pocesar
reviewed
Feb 28, 2017
| if (_.has(command, 'error') && (!_.isNull(command['error']) && !_.isEmpty(command['error']))) { | ||
| // we have an error, we need to act on that, regardless of other members in the command received | ||
| throw new Error(command); | ||
| throw Object.assign(new Error(command.error[1]), { |
Owner
There was a problem hiding this comment.
doesn't this change the error to become an object? can it still be throwable?
Contributor
Author
There was a problem hiding this comment.
yep, it is still ok :)
All the tests works 👍
Contributor
Author
There was a problem hiding this comment.
btw, tiny tip, you can update version using this:
https://docs.npmjs.com/cli/version
it will create a nice version tag and will commit it.
makes package updating a little more consistent :)
Owner
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.