Skip to content

Add typescript to demo package.json and add more descriptive filters for demo/src/dialog.tab.ts #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2022

Conversation

Cyan903
Copy link
Contributor

@Cyan903 Cyan903 commented Mar 5, 2022

I found this repository while searching for an electron dialog bridge. This works great for what I'm using it for, but I had some small issues setting up the demo. npm build would not run because typescript wasn't installed. After I installed that, the demo worked perfectly.

I also thought it would be a good idea to make the filter name more descriptive. When trying to open a file, some file managers (like Thunar) do not show the extension and only show the name which is somewhat confusing.

image

Other than that, this bridge works great. Thanks for making this. I was looking forever for something like this.

@poirierlouis
Copy link
Owner

Hello,
Thank you for your feedback.
In deed, the demo is not complete and missing stuff.

I'll take a look into your PR.

@poirierlouis poirierlouis self-assigned this Mar 12, 2022
@poirierlouis poirierlouis added the good first issue Good for newcomers label Mar 12, 2022
@poirierlouis poirierlouis merged commit c9e1703 into poirierlouis:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants