Skip to content

Conversation

@issyl0
Copy link
Contributor

@issyl0 issyl0 commented Jan 12, 2025

  • Following on from Fix (or ignore) RuboCop offenses prawn-dev#2 like I said I would.
  • Interestingly RuboCop didn’t complain about what I expected it to complain about (the non-parenthesized puts, for one) so I don’t know what I’m doing wrong?

- The autocorrections break everything, so I'll leave these to someone more experienced with the codebase.
- These are public APIs and not going to change soon.
Copy link
Member

@pointlessone pointlessone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@pointlessone pointlessone merged commit 6b91b63 into prawnpdf:master Jan 13, 2025
23 of 25 checks passed
@pointlessone
Copy link
Member

@issyl0 Thank you.

@issyl0 issyl0 deleted the bump-prawn-dev-and-fix-rubocop branch January 14, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants