Fix wrong assertions after core fix #601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With fixing the bug in Preact that would bail in cascading renders we are now seeing an error in the tests where the
SignalValuewould previously not re-render on the updates. Notice how we would assert the following beforeNotice that last discrepancy, we previously would not rerender the optimized SignalValue and hence show the wrong result. This is very prefresh specific but still worth highlighting