Skip to content

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Dec 2, 2025

With fixing the bug in Preact that would bail in cascading renders we are now seeing an error in the tests where the SignalValue would previously not re-render on the updates. Notice how we would assert the following before

  • Count: 0
  • Increment --> Count: 1
  • Update Count --> count
  • count: 1
  • Increment --> count: 1

Notice that last discrepancy, we previously would not rerender the optimized SignalValue and hence show the wrong result. This is very prefresh specific but still worth highlighting

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2025

⚠️ No Changeset found

Latest commit: 24fa2b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoviDeCroock JoviDeCroock merged commit 5d63c43 into main Dec 2, 2025
1 check passed
@JoviDeCroock JoviDeCroock deleted the fix-tests-after-core-fix branch December 2, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants