Skip to content

Hacktoberfest fixes #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jb3 merged 5 commits into from
Sep 30, 2020
Merged

Hacktoberfest fixes #466

jb3 merged 5 commits into from
Sep 30, 2020

Conversation

@jb3
Copy link
Member

@jb3 jb3 commented Sep 30, 2020 •
edited
Loading

Description

This PR fixes a set of issues with the Hacktoberfest commands.

  • It allows the commands to be used in September and November so that the early start and late finish (Hacktoberfest starts and ends where it is October anywhere in the world) are factored in. This is also relevant because Hacktober now uses September as "Pre-temper" where maintainers should get issues ready.
  • Updates the Hacktoberfest command branding to 2020
  • References that you can also plant a tree
  • Updates the timeleft command to use the Hacktoberfest dates, not just the month of October.

Screenshots

image

image

Did you:

  • Join the Python Discord Community?
  • If dependencies have been added or updated, run pipenv lock?
  • Lint your code (pipenv run lint)?
  • Set the PR to allow edits from contributors?

@jb3 jb3 marked this pull request as ready for review September 30, 2020 21:53
@jb3 jb3 requested a review from a team as a code owner September 30, 2020 21:53
@jb3 jb3 requested review from GhostofGoes and kosayoda September 30, 2020 21:53
@ghost ghost added the needs 2 approvals label Sep 30, 2020
Den4200
Den4200 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@Den4200 Den4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Numerlor
Numerlor approved these changes Sep 30, 2020
View reviewed changes
bot/exts/halloween/timeleft.py Outdated
Comment on lines 53 to 54
await ctx.send(f"There are {days} days, {hours} hours and {minutes}"
" minutes left until the end of Hacktober.")
Copy link
Contributor

@Numerlor Numerlor Sep 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await ctx.send(f"There are {days} days, {hours} hours and {minutes}"
" minutes left until the end of Hacktober.")
await ctx.send(
f"There are {days} days, {hours} hours and {minutes}"
f" minutes left until the end of Hacktober."
)

Copy link
Member Author

@jb3 jb3 Sep 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 60a024c, formatting on this suggestion seemed a bit off.

@ghost ghost removed the needs 1 approval label Sep 30, 2020
@jb3 jb3 merged commit 83b6908 into master Sep 30, 2020
@jb3 jb3 deleted the joseph/hacktoberfest-fixes branch September 30, 2020 23:15
@hedyhli hedyhli mentioned this pull request Oct 20, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Den4200 Den4200 Den4200 approved these changes

@GhostofGoes GhostofGoes Awaiting requested review from GhostofGoes

@kosayoda kosayoda Awaiting requested review from kosayoda

+1 more reviewer

@Numerlor Numerlor Numerlor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jb3 @Numerlor @Den4200