Skip to content

Conversation

@jb3
Copy link
Member

@jb3 jb3 commented Dec 2, 2018

This adds a few features regarding countdowns and notifications.

  • Role subscriptions (I've already added the role in Discord)
  • Role notifications
  • Countdown command
  • Countdown status

I've added a couple config things but they default to things already in the server so no environment changes are required.

@jb3 jb3 added the type: feature Relating to the functionality of the application. label Dec 2, 2018
Copy link
Contributor

@jerbob jerbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@sco1 sco1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only general caveat I can see is to be cognizant of the rate limits with the regular presence change. Discord's Rich Presence Payload supports an end timestamp for "time remaining" which may be better suited in the long run.

Looks great for now, but there's some more fun tinkering with Rich Presence that can still be done.

@jb3
Copy link
Member Author

jb3 commented Dec 2, 2018

I think the ratelimit for presence changes is pretty low (iirc once every 15 seconds, I will check).

Bots cannot make use of rich presence at this time because it is something controlled via a local websocket which bots don't have.

@jb3 jb3 merged commit 325074c into master Dec 2, 2018
@jb3 jb3 deleted the aoc-countdown branch December 2, 2018 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature Relating to the functionality of the application.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants