Fix tests failing on Windows due to git EOL conversion #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests were failing because they were performing binary comparison with test files for which git can perform EOL (end of line) conversion. On Windows by default this means that the '\n' are replaced by '\r\n'. The added .gitattributes file disables the EOL conversion for the two folders containing text files used by the tests. With this (and rechecking out the two folders) all the tests now pass successfully on Windows.
4762810 to
0a8e9c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were failing because they were performing binary comparison with
test files for which git can perform EOL (end of line) conversion. On Windows
by default this means that the '\n' are replaced by '\r\n'.
The added .gitattributes file disables the EOL conversion for the two folders
containing text files used by the tests. With this (and rechecking out the two
folders) all the tests now pass successfully on Windows.