[mypyc] Borrow operands of several primitives #12810
Merged
+539
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes to borrowing
We conservatively only support when checking against simple native classes.
ilevkivskyi
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrow an operand such as
x.y(attribute of a native class) in various contextswhen it's safe to do so. This reduces the number of incref/decref operations we
need to perform. This continues work started in #12805.
These cases now support borrowing (for some subexpressions, in some contexts):
x.y is Nonelen(x.y)(if the operand is a list)isinstance(x.y, C)x.y[a.b]x.y.z = 1