Skip to content

Optimize mypy.fastparse (Python 3 only) #5722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 3, 2018
Merged

Optimize mypy.fastparse (Python 3 only) #5722

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
599ad73
Optimize parser
JukkaL Oct 2, 2018
b10d095
Reduce the use of decorators
JukkaL Oct 2, 2018
5f02e7f
Additional micro-optimizations
JukkaL Oct 2, 2018
0d7b569
Optimize visitor implementation
JukkaL Oct 2, 2018
7b8445a
More micro optimizations
JukkaL Oct 2, 2018
3038fd9
Optimize isinstance checks a bit
JukkaL Oct 2, 2018
d2e6c47
Refactor decorators away
JukkaL Oct 2, 2018
6229b11
Fix type check
JukkaL Oct 2, 2018
9b8a9f7
Fix lint
JukkaL Oct 2, 2018
2a35177
Fix some line numbers
JukkaL Oct 2, 2018
200c116
More parser micro-optimizations
JukkaL Oct 3, 2018
d16ac7e
Further micro-optimizations
JukkaL Oct 3, 2018
49c58e6
Remove dead code
JukkaL Oct 3, 2018
d4d9289
Update based on review
JukkaL Oct 3, 2018
7ac5711
This method is actually not dead (oops)
JukkaL Oct 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update based on review
  • Loading branch information
@JukkaL
JukkaL committed Oct 3, 2018
commit d4d928916351264c9f4e215ac5a5e18f5b501d34
8 changes: 1 addition & 7 deletions mypy/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,4 @@ def console_entry() -> None:


if __name__ == '__main__':
import cProfile
import pstats

cProfile.run('main(None)', 'profstats')
p = pstats.Stats('profstats')
p.sort_stats('time').print_stats(40)
#main(None)
main(None)
2 changes: 0 additions & 2 deletions mypy/fastparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,15 +202,13 @@ def translate_expr_list(self, l: Sequence[AST]) -> List[Expression]:
res = [] # type: List[Expression]
for e in l:
exp = self.visit(e)
# assert isinstance(exp, Expression)
res.append(exp)
return res

def translate_stmt_list(self, l: Sequence[AST]) -> List[Statement]:
res = [] # type: List[Statement]
for e in l:
stmt = self.visit(e)
# assert isinstance(stmt, Statement)
res.append(stmt)
return res

Expand Down