Skip to content

Add support for dmypy on Windows #5859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 56 commits into from
Nov 27, 2018
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
63aa4e2
Initial dmypy for Windows work
emmatyping Oct 26, 2018
abc64b7
Fixes related to dmypy server on Windows
emmatyping Oct 30, 2018
cf33bfa
Get dmypy start,stop,run,kill,check,restart working! :tada:
emmatyping Oct 31, 2018
54859da
Only use _winapi on Windows
emmatyping Oct 31, 2018
f760e16
Guard _winapi import dmypy_server
emmatyping Oct 31, 2018
966117c
Get dmypy status working on Windows
emmatyping Oct 31, 2018
68ee937
Add support for timeout
emmatyping Oct 31, 2018
f6a42c3
Fix lint on Linux
emmatyping Oct 31, 2018
168e177
Change a while 1 to a while True
emmatyping Oct 31, 2018
3e0d12e
Minor refactoring
emmatyping Oct 31, 2018
87e61c5
Move conditional imports to end of imports
emmatyping Oct 31, 2018
1883c31
Minor fixes, corrections, simplifications
emmatyping Oct 31, 2018
7932bb7
Merge branch 'master' of github.com:python/mypy into windmypy
emmatyping Oct 31, 2018
8fb7203
Remove outdated docs
emmatyping Nov 5, 2018
69d04dd
Respond to Guido's comments
emmatyping Nov 7, 2018
968e07c
Lower timeout back down to 5s
emmatyping Nov 8, 2018
037267a
Major refactoring into separate IPC module
emmatyping Nov 12, 2018
db202c2
Fix typing import for Python 3.5.1
emmatyping Nov 12, 2018
55250a8
Correct out of date comments and remove unused imports
emmatyping Nov 12, 2018
f066484
Quote types so they don't need to be imported at runtime
emmatyping Nov 12, 2018
54cba38
Minor code cleanup
emmatyping Nov 12, 2018
072518b
Remove unused loop
emmatyping Nov 12, 2018
f033c54
Remove some more unused imports
emmatyping Nov 12, 2018
768a2bf
Make pipe name and options file unique
emmatyping Nov 14, 2018
32ef5c9
Merge branch 'master' into windmypy
msullivan Nov 16, 2018
962072a
Move a conditional def out of IPCBase
msullivan Nov 16, 2018
8d909c5
Remove dead code
emmatyping Nov 16, 2018
7896a73
Merge branch 'windmypy' of github.com:ethanhs/mypy into windmypy
emmatyping Nov 16, 2018
eca5beb
Fix lint failure
emmatyping Nov 16, 2018
941b1f2
Move to passing options via command instead of file
emmatyping Nov 16, 2018
06459a8
Unify interface of daemonize
emmatyping Nov 16, 2018
1feaf0e
Add comment about IPC behavior
emmatyping Nov 16, 2018
34bd86a
Move process status checking and killing into dmypy_os
emmatyping Nov 16, 2018
c4d0bad
Add test for IPC
emmatyping Nov 16, 2018
ed4548d
Handle ERROR_PIPE_CONNECTED
emmatyping Nov 16, 2018
681408f
Give the server more time to get set up in testipc?
emmatyping Nov 16, 2018
f484143
Fix unix daemonize typo (and slightly regeneralize)
msullivan Nov 16, 2018
512c60e
Fix IPC tests
emmatyping Nov 16, 2018
09b4913
Fix typecheck of ipc tests
emmatyping Nov 16, 2018
d2695ca
Reraise if exceptions occure and unify IPC initialization
emmatyping Nov 17, 2018
76e0539
Merge branch master into ethanhs/windmypy
emmatyping Nov 20, 2018
4956188
Get tests passing on Windows
emmatyping Nov 20, 2018
4e0dcc1
Merge branch 'windmypy' of github.com:ethanhs/mypy into windmypy
emmatyping Nov 20, 2018
842712e
Try an empty string/quotes instead of single quotes
emmatyping Nov 20, 2018
5d9e149
Really fix daemon tests
emmatyping Nov 20, 2018
959f89a
Remove busy wait and give better debug info
emmatyping Nov 20, 2018
326758c
Temporary debug info
emmatyping Nov 20, 2018
d806282
Reuse NamedPipe for multiple connections
emmatyping Nov 22, 2018
989ca72
Conditionally import Options in dmypy
emmatyping Nov 22, 2018
da719d6
Remove debug info
emmatyping Nov 22, 2018
c2d8d90
Merge upstream into windmypy
emmatyping Nov 27, 2018
a732a1e
Be more eager in removing status file
emmatyping Nov 27, 2018
dae10eb
Remove redundant parens
emmatyping Nov 27, 2018
9de1b88
Use random bytes for NamedPipe name
emmatyping Nov 27, 2018
f3b8bb6
Document timeouts on Windows
emmatyping Nov 27, 2018
0c43879
Add line in note
emmatyping Nov 27, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Conditionally import Options in dmypy
  • Loading branch information
emmatyping committed Nov 22, 2018
commit 989ca7278d8256078fe34ad1a85b49630a2dbbd2
3 changes: 2 additions & 1 deletion mypy/dmypy.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from mypy.dmypy_util import STATUS_FILE, receive
from mypy.ipc import IPCClient, IPCException
from mypy.dmypy_os import alive, kill
from mypy.options import Options

from mypy.version import __version__

# Argument parser. Subparsers are tied to action functions by the
Expand Down Expand Up @@ -367,6 +367,7 @@ def do_daemon(args: argparse.Namespace) -> None:
# Lazy import so this import doesn't slow down other commands.
from mypy.dmypy_server import Server, process_start_options
if args.options_data:
from mypy.options import Options
options_dict, timeout, log_file = pickle.loads(base64.b64decode(args.options_data))
options_obj = Options()
options = options_obj.apply_changes(options_dict)
Expand Down