Skip to content

Fixes to column number reporting #7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 27, 2019
Prev Previous commit
Next Next commit
Fix one more test case
  • Loading branch information
JukkaL committed Jun 27, 2019
commit 93e1165012646524388f4306f2b6d8301cfc8e5a
13 changes: 7 additions & 6 deletions test-data/unit/check-overloading.test
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
-- Test cases for function overloading
[case testOverloadNotImportedNoCrash]
# flags: --new-semantic-analyzer
@overload
def f(a): pass
@overload
Expand All @@ -9,18 +10,18 @@ f(0)

@overload # E: Name 'overload' is not defined
def g(a:int): pass
def g(a): pass # E: Name 'g' already defined on line 8
def g(a): pass # E: Name 'g' already defined on line 9
g(0)

@something # E: Name 'something' is not defined
def r(a:int): pass
def r(a): pass # E: Name 'r' already defined on line 13
def r(a): pass # E: Name 'r' already defined on line 14
r(0)
[out]
main:1: error: Name 'overload' is not defined
main:3: error: Name 'f' already defined on line 1
main:3: error: Name 'overload' is not defined
main:5: error: Name 'f' already defined on line 1
main:2: error: Name 'overload' is not defined
main:4: error: Name 'f' already defined on line 2
main:4: error: Name 'overload' is not defined
main:6: error: Name 'f' already defined on line 2

[case testTypeCheckOverloadWithImplementation]
from typing import overload, Any
Expand Down