Skip to content

support channels last inputs in xnnpack #11118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2025
Merged

support channels last inputs in xnnpack #11118

merged 3 commits into from
Jun 4, 2025

Conversation

leafs1
Copy link
Contributor

@leafs1 leafs1 commented May 23, 2025

Summary

Support channels last inputs in xnnpack

Test plan

Wrote tests taking combinations of channels last/first inputs with ops requiring inputs of both forms.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11118

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7baf5de with merge base 0e35c30 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2025
@leafs1 leafs1 requested a review from GregoryComer as a code owner May 23, 2025 22:37
@leafs1
Copy link
Contributor Author

leafs1 commented May 27, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label May 27, 2025
@leafs1 leafs1 force-pushed the milestone1 branch 8 times, most recently from 6612a87 to 3b16f34 Compare May 27, 2025 23:25
mcr229
mcr229 requested changes May 29, 2025
View reviewed changes
@facebook-github-bot
Copy link
Contributor

@leafs1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@leafs1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mcr229
mcr229 reviewed May 30, 2025
View reviewed changes
mcr229
mcr229 reviewed May 30, 2025
View reviewed changes
@facebook-github-bot
Copy link
Contributor

@leafs1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@leafs1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@leafs1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@leafs1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@leafs1 leafs1 merged commit 554db00 into pytorch:main Jun 4, 2025
96 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcr229 mcr229 mcr229 approved these changes

@jathu jathu Awaiting requested review from jathu

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

@manuelcandales manuelcandales Awaiting requested review from manuelcandales

@swolchok swolchok Awaiting requested review from swolchok

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka

@jackzhxng jackzhxng Awaiting requested review from jackzhxng

@iseeyuan iseeyuan Awaiting requested review from iseeyuan

@tarun292 tarun292 Awaiting requested review from tarun292

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@shoumikhin shoumikhin Awaiting requested review from shoumikhin

@cccclai cccclai Awaiting requested review from cccclai

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leafs1 @facebook-github-bot @GregoryComer @mcr229