Skip to content

Bump tokenizers #11510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Bump tokenizers #11510

merged 1 commit into from
Jun 10, 2025

Conversation

jackzhxng
Copy link
Contributor

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11510

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3175bee with merge base 7164d03 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 10, 2025
@guangy10
Copy link
Contributor

What has been fixed? If it's fixing the reported tokenizer issue, can we at least rerun the app with previously failed model+tokenizer in the CI?

@jackzhxng jackzhxng force-pushed the jz/bump-tokenizers-2 branch from cc14861 to 3175bee Compare June 10, 2025 02:02
@jackzhxng jackzhxng added the release notes: none Do not include this in the release notes label Jun 10, 2025
@jackzhxng
Copy link
Contributor Author

@guangy10 some recent tokenizer changes broke the cmake for the regex lookahead, so this fixes it

@jackzhxng jackzhxng merged commit acc3e25 into main Jun 10, 2025
96 of 97 checks passed
@jackzhxng jackzhxng deleted the jz/bump-tokenizers-2 branch June 10, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@kimishpatel kimishpatel kimishpatel approved these changes

@iseeyuan iseeyuan Awaiting requested review from iseeyuan

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackzhxng @guangy10 @mergennachin @kimishpatel @facebook-github-bot