Skip to content

Conversation

@marten-seemann
Copy link
Member

Part of #4124.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds qlogging support for GOAWAY frames in HTTP/3, enabling proper logging and monitoring of connection closure events. This is part of a larger effort to enhance qlogging capabilities.

  • Adds GoAwayFrame struct and encoding logic for qlogging GOAWAY frames
  • Implements qlogging events for both frame creation and parsing in GOAWAY scenarios
  • Adds test coverage for the new GoAwayFrame functionality

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
http3/server.go Added qlogging of GOAWAY frame creation during server graceful shutdown
http3/qlog/frame.go Implemented GoAwayFrame struct and its encoding method for qlog output
http3/qlog/frame_test.go Added test coverage for GoAwayFrame encoding
http3/qlog/event.go Added HasValues method to RawInfo and conditional raw data logging
http3/conn_test.go Enhanced tests to verify GOAWAY frame qlogging functionality
http3/conn.go Added qlogging of GOAWAY frame parsing in connection handler

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

❌ Patch coverage is 65.71429% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.08%. Comparing base (7796175) to head (0b91df2).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
http3/qlog/event.go 50.00% 4 Missing and 2 partials ⚠️
http3/server.go 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5376      +/-   ##
==========================================
+ Coverage   83.04%   83.08%   +0.03%     
==========================================
  Files         158      158              
  Lines       18963    18990      +27     
==========================================
+ Hits        15747    15776      +29     
+ Misses       2591     2589       -2     
  Partials      625      625              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann changed the title http3: add support for qlogging GOAWAY frames http3: qlog sent and received GOAWAY frames Oct 11, 2025
@marten-seemann marten-seemann merged commit f330d0e into master Oct 11, 2025
38 checks passed
@marten-seemann marten-seemann deleted the http3-qlog-goaway branch October 11, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants