-
Notifications
You must be signed in to change notification settings - Fork 4
Make a separate codebase for the client #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abrookins
wants to merge
13
commits into
main
Choose a base branch
from
feature/separate-client-codebase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7,735
−3,002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a standalone Python client package and CI workflows, and refactors ULID generation.
- Introduces a new
agent-memory-client
codebase with its ownpyproject.toml
, tests, and GitHub Actions workflow for publishing to PyPI. - Updates server
pyproject.toml
to add project URLs and temporarily stub version, and pins the client dependency to a local path.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
tests/test_long_term_memory.py | Switched ULID generation to ulid.new() and updated imports. |
tests/test_client_*.py | Updated imports to use agent_memory_client , added mock-response logic. |
tests/conftest.py | Replaced ulid.ULID() with ulid.new() . |
pyproject.toml | Commented out server version, added local client dependency, project URLs |
agent_memory_server/**/*.py | Replaced server-side ULID() usage with ulid.new() . |
agent-memory-client/ | Entire new client package, tests, docs, and CI workflow. |
.github/workflows/agent-memory-client.yml | CI workflow for testing and publishing the client package. |
Comments suppressed due to low confidence (1)
pyproject.toml:7
- The version field is commented out, leaving no version defined for the package. Please restore
version = "0.9.0"
(or the intended release) to ensure the build and publishing steps have a version to use.
# version = "0.9.0"
Co-authored-by: Copilot <[email protected]>
…' into feature/separate-client-codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a separate codebase for the client and sets up workflows to publish client releases to PyPI.