Skip to content

Conversation

@kewynakshlley
Copy link
Collaborator

@kewynakshlley kewynakshlley commented Oct 27, 2025

Summary by cubic

Adds inbound email receiving (beta) to the Java SDK so you can list and fetch received emails and their attachments. Exposes a new Receiving service via Resend.receiving().

  • New Features
    • Receiving service: get(emailId), list(), and list(ListParams) for inbound emails.
    • Attachment APIs: listAttachments(emailId), listAttachments(emailId, ListParams), getAttachment(emailId, attachmentId) returning download_url.
    • New models: ReceivedEmail, ReceivedEmailAttachment, AttachmentDetails, ListReceivedEmailsResponse, ListAttachmentsResponse.
    • Resend facade updated with receiving() accessor.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 9 files

Prompt for AI agents (all 2 issues)

Understand the root cause of the following 2 issues and fix them.


<file name="src/test/java/com/resend/services/receiving/ReceivingTest.java">

<violation number="1" location="src/test/java/com/resend/services/receiving/ReceivingTest.java:27">
Because the tests replace `Receiving` with a Mockito mock, each case only stubs the mock and asserts on the same stubbed values. This never exercises the real Receiving service, so regressions will slip through. Please instantiate and exercise the real implementation (or a higher-level client) instead of mocking the class under test.</violation>
</file>

<file name="src/main/java/com/resend/services/receiving/Receiving.java">

<violation number="1" location="src/main/java/com/resend/services/receiving/Receiving.java:81">
Rule violated: **Initialisms and Acronyms Naming Conventions**

The identifier `URLHelper` keeps the `URL` acronym fully uppercase, violating the Initialisms and Acronyms Naming Conventions rule that requires acronyms to be camel-cased (e.g., `UrlHelper`) for consistency and readability.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

lucasfcosta
lucasfcosta previously approved these changes Oct 28, 2025
@kewynakshlley kewynakshlley merged commit 464efd7 into main Oct 28, 2025
3 checks passed
@kewynakshlley kewynakshlley deleted the feat/inbound-emails branch October 28, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants