fix for withdrawLegacyRPLFor/_withdrawLegacyRPLFor #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for withdrawLegacyRPLFor and _withdrawLegacyRPLFor using msg.sender and not the provided _nodeAddress.
7a8aefe to
e69b728
Compare
fdfb7d6 to
8f0a026
Compare
2e600cb to
9b0fee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I do not understand the node address of withdrawLegacyRPLFor and _withdrawLegacyRPLFor use msg.sender and not the provided _nodeAddress. I think this is an error and it should use the _nodeAddress. This PR fixes the issue.