Skip to content

ci: Use cargo --locked where possible#23980

Merged
kjarosh merged 1 commit into
ruffle-rs:masterfrom
kjarosh:cargo-locked
Jun 15, 2026
Merged

ci: Use cargo --locked where possible#23980
kjarosh merged 1 commit into
ruffle-rs:masterfrom
kjarosh:cargo-locked

Conversation

@kjarosh

@kjarosh kjarosh commented Jun 14, 2026

Copy link
Copy Markdown
Member

Description

Not using --locked causes cargo to use newer dependencies, which may break the build and cause flakiness.

A real world example: https://github.com/ruffle-rs/ruffle/actions/runs/27492387243/attempts/1. The 0.3.0 release failed because wasm-bindgen compilation failed due to dependency issues.

Testing

Not tested.

Checklist

  • I, a human, have self-reviewed this PR and fully understand the changes within.
  • I have made or updated tests where possible.
  • All of my commits are properly scoped, compile successfully, and pass all tests.
  • This PR does not make sense to split up into smaller PRs.
  • An LLM was involved in the authoring of this code.

@kjarosh kjarosh requested a review from torokati44 June 14, 2026 22:38
@kjarosh kjarosh added A-build Area: Build scripts & CI T-fix Type: Bug fix (in something that's supposed to work already) labels Jun 14, 2026
Not using --locked causes cargo to use newer dependencies, which may
break the build and cause flakiness.
@kjarosh kjarosh enabled auto-merge (rebase) June 15, 2026 08:45
@kjarosh kjarosh merged commit 8068973 into ruffle-rs:master Jun 15, 2026
24 of 26 checks passed
@kjarosh kjarosh deleted the cargo-locked branch June 15, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-build Area: Build scripts & CI T-fix Type: Bug fix (in something that's supposed to work already)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants