chore: Add modernize linter

[lukemassa]

what

Add modernize as a linter and run it.

why

My code editor was complaining about some modernize issues, it seemed worth adding to our linter.

Modernize is maintained by the go team (https://pkg.go.dev/golang.org/x/tools/[email protected]/internal/analysis/modernize/cmd/modernize) and replaces existing code with equivalent code following newer go idioms.

I looked at the PR closely and all the changes look reasonable and/or improvements.

In addition to running modernize, I had to do some code level clean up, all pretty straightforward.

tests

N/A

references

N/A