Skip to content

Conversation

@bcfre
Copy link
Collaborator

@bcfre bcfre commented Sep 17, 2025

Ⅰ. Motivation

KEP: adding ControllerRevision support to the RoleBasedGroup (RBG) object to store its historical states.

Ⅱ. Modifications

kep proposal

Ⅲ. Does this pull request fix one issue?

fixes #21

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

VI. Special notes for reviews

Checklist

  • Format your code make fmt.
  • Add unit tests or integration tests.
  • Update the documentation related to the change.

@bcfre bcfre changed the title add kep 30 [KEP-31] Adding ControllerRevision support to the RoleBasedGroup Sep 17, 2025
@bcfre bcfre changed the title [KEP-31] Adding ControllerRevision support to the RoleBasedGroup [KEP-31]: Adding ControllerRevision support to the RoleBasedGroup Sep 17, 2025
@bcfre bcfre force-pushed the controllerrevision branch 2 times, most recently from 7bd3142 to ba9745c Compare September 22, 2025 12:04
Signed-off-by: 柏存 <[email protected]>
@bcfre bcfre force-pushed the controllerrevision branch from ba9745c to 536d807 Compare October 15, 2025 02:57
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@RongGu RongGu requested a review from Copilot October 27, 2025 09:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a KEP (Kubernetes Enhancement Proposal) for adding ControllerRevision support to the RoleBasedGroup (RBG) object, enabling historical state tracking and version awareness for RBG configurations.

Key Changes:

  • Proposes using Kubernetes ControllerRevision resources to store historical RBG states
  • Introduces per-role revision tracking to prevent unintended cross-role updates
  • Maintains backward compatibility with existing semantic equality-based update mechanisms

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
keps/31-rbg-controller-revision/kep.yaml Metadata file defining the KEP proposal including authorship, status, and milestone information
keps/31-rbg-controller-revision/README.md Detailed KEP documentation explaining motivation, design, API changes, and implementation approach for ControllerRevision support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sgl-project sgl-project deleted a comment from Copilot AI Oct 27, 2025
@RongGu RongGu requested a review from Copilot October 27, 2025 12:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cheyang cheyang merged commit 72ad2e5 into sgl-project:main Oct 30, 2025
3 checks passed
@bcfre bcfre deleted the controllerrevision branch October 30, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] How to change the unit scale of P or D at the RGB layer, given that the P/D scale of LWS becomes unmodifiable once it is determined?

3 participants