-
Notifications
You must be signed in to change notification settings - Fork 37
[KEP-31]: Adding ControllerRevision support to the RoleBasedGroup #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7bd3142 to
ba9745c
Compare
Signed-off-by: 柏存 <[email protected]>
ba9745c to
536d807
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cheyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a KEP (Kubernetes Enhancement Proposal) for adding ControllerRevision support to the RoleBasedGroup (RBG) object, enabling historical state tracking and version awareness for RBG configurations.
Key Changes:
- Proposes using Kubernetes ControllerRevision resources to store historical RBG states
- Introduces per-role revision tracking to prevent unintended cross-role updates
- Maintains backward compatibility with existing semantic equality-based update mechanisms
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| keps/31-rbg-controller-revision/kep.yaml | Metadata file defining the KEP proposal including authorship, status, and milestone information |
| keps/31-rbg-controller-revision/README.md | Detailed KEP documentation explaining motivation, design, API changes, and implementation approach for ControllerRevision support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: bcfre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ⅰ. Motivation
KEP: adding ControllerRevision support to the RoleBasedGroup (RBG) object to store its historical states.
Ⅱ. Modifications
kep proposal
Ⅲ. Does this pull request fix one issue?
fixes #21
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.