Skip to content

Conversation

@gujingit
Copy link
Collaborator

@gujingit gujingit commented Sep 18, 2025

Ⅰ. Motivation

Support rollingUpdate with partition. This is helpful in incremental rollout strategies like canary deployments or interactive rollout strategies for multiple replicas like xPyD deployments.

Ⅱ. Modifications

type RollingUpdate struct {
        // add partition configuration
	Partition      *int32             `json:"partition,omitempty"`
	MaxUnavailable intstr.IntOrString `json:"maxUnavailable,omitempty"`
	MaxSurge       intstr.IntOrString `json:"maxSurge,omitempty"`
}

Ⅲ. Does this pull request fix one issue?

None

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

TestLeaderWorkerSetReconciler_Reconciler()
TestStatefulSetReconciler_Reconciler()

Ⅴ. Describe how to verify it

follow the update-strategy.md

VI. Special notes for reviews

Checklist

  • Format your code make fmt.
  • Add unit tests or integration tests.
  • Update the documentation related to the change.

@gujingit gujingit force-pushed the feature/partition branch 4 times, most recently from a83d2ad to 3fade5b Compare September 18, 2025 09:59
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang cheyang merged commit cd1a9b2 into sgl-project:main Sep 19, 2025
3 checks passed
@gujingit gujingit deleted the feature/partition branch September 23, 2025 06:37
Copilot AI mentioned this pull request Dec 22, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants