KEP-8: Reduce YAML Duplication via RoleTemplates #70
Conversation
Address review feedback: - Clarify LWS merging behavior with detailed flowchart - Add rbgctl dry-run mitigation - Include ControllerRevision rollback testing - Move ExtraArgs to Future Considerations - Update milestone target to v0.6.0 Phase 2 deferred pending community feedback on Phase 1 adoption.
Address review feedback: - Clarify LWS merging behavior with detailed flowchart - Add rbgctl dry-run mitigation - Include ControllerRevision rollback testing - Move ExtraArgs to Future Considerations - Update milestone target to v0.6.0 Phase 2 deferred pending community feedback on Phase 1 adoption.
Address review feedback: - Clarify LWS merging behavior with detailed flowchart - Add rbgctl dry-run mitigation - Include ControllerRevision rollback testing - Move ExtraArgs to Future Considerations - Update milestone target to v0.6.0 Phase 2 deferred pending community feedback on Phase 1 adoption.
|
Great design. I have one final comment. Please supplement the Controller Behavior section with the update workflow and describe how the ControllerRevision changes during the roleTemplate update. |
There was a problem hiding this comment.
Pull Request Overview
This KEP introduces roleTemplates to reduce YAML duplication in RoleBasedGroup (RBG) configurations by approximately 20%. The proposal enables platform teams to define reusable Pod configurations that multiple roles can reference, using Kubernetes Strategic Merge Patch for configuration merging.
Key Changes:
- Introduces
spec.roleTemplatesfor reusable Pod configurations withtemplateRefsupport - Documents Strategic Merge Patch behavior for volumes, env vars, resources, and commands
- Adds dry-run capability and ControllerRevision rollback testing
- Defers command parameter deduplication (extraArgs) to future considerations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| keps/8-reduce-yaml-duplication/kep.yaml | Defines KEP metadata including authors, reviewers, status, and milestone targeting v0.6.0 |
| keps/8-reduce-yaml-duplication/README.md | Complete KEP specification covering motivation, design details, API examples, merge behavior, controller logic, and test plans |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
/lgtm |
Summary
This KEP introduces
roleTemplatesin RBG to reduce YAML duplication by ~20%.Changes
spec.roleTemplatesfor reusable Pod configurationsPhase 2 Status
ExtraArgs (command parameter deduplication) deferred to Future Considerations pending Phase 1 feedback.
Addresses Review Feedback