chore(codegen): Generate instanceSet related go-client codes #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds generated client-go code for the new InstanceSet Kubernetes custom resource. The changes include listers, informers, clientsets, fake clients, and apply configurations following standard Kubernetes code generation patterns.
Key changes:
- Generated lister and informer implementations for InstanceSet resources
- Added client interfaces and implementations for InstanceSet CRUD operations including scale subresource support
- Generated apply configurations for InstanceSet and related types (Lifecycle, LifecycleHook, InstanceTemplate, etc.)
- Removed an extraneous blank line in the InstanceSet API type definition
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/workloads/v1alpha1/instanceset_types.go | Removed blank line before kubebuilder annotations (formatting cleanup) |
| client-go/listers/workloads/v1alpha1/instanceset.go | Generated lister implementation for InstanceSet resources |
| client-go/listers/workloads/v1alpha1/expansion_generated.go | Added expansion interfaces for InstanceSet lister customization |
| client-go/informers/externalversions/workloads/v1alpha1/interface.go | Added InstanceSets() method to informer interface |
| client-go/informers/externalversions/workloads/v1alpha1/instanceset.go | Generated shared informer implementation for InstanceSet |
| client-go/informers/externalversions/generic.go | Registered InstanceSet in the generic informer factory |
| client-go/clientset/versioned/typed/workloads/v1alpha1/workloads_client.go | Added InstanceSets() accessor method to the workloads client |
| client-go/clientset/versioned/typed/workloads/v1alpha1/instanceset.go | Generated client implementation with CRUD operations and scale subresource support |
| client-go/clientset/versioned/typed/workloads/v1alpha1/generated_expansion.go | Added expansion interface for InstanceSet client customization |
| client-go/clientset/versioned/typed/workloads/v1alpha1/fake/fake_workloads_client.go | Added fake InstanceSets() method for testing |
| client-go/clientset/versioned/typed/workloads/v1alpha1/fake/fake_instanceset.go | Generated fake client for InstanceSet testing |
| client-go/applyconfiguration/workloads/v1alpha1/lifecyclehook.go | Generated apply configuration for LifecycleHook type |
| client-go/applyconfiguration/workloads/v1alpha1/lifecycle.go | Generated apply configuration for Lifecycle type |
| client-go/applyconfiguration/workloads/v1alpha1/instancetemplate.go | Generated apply configuration for InstanceTemplate type |
| client-go/applyconfiguration/workloads/v1alpha1/instancesetupdatestrategy.go | Generated apply configuration for InstanceSetUpdateStrategy type |
| client-go/applyconfiguration/workloads/v1alpha1/instancesetstatus.go | Generated apply configuration for InstanceSetStatus type |
| client-go/applyconfiguration/workloads/v1alpha1/instancesetspec.go | Generated apply configuration for InstanceSetSpec type |
| client-go/applyconfiguration/workloads/v1alpha1/instancesetscalestrategy.go | Generated apply configuration for InstanceSetScaleStrategy type |
| client-go/applyconfiguration/workloads/v1alpha1/instancesetcondition.go | Generated apply configuration for InstanceSetCondition type |
| client-go/applyconfiguration/workloads/v1alpha1/instanceset.go | Generated apply configuration for InstanceSet with metadata methods |
| client-go/applyconfiguration/workloads/v1alpha1/inplaceupdatestrategy.go | Generated apply configuration for InPlaceUpdateStrategy type |
| client-go/applyconfiguration/utils.go | Registered all new apply configuration types in ForKind() function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
Ⅱ. Modifications
Generate InstanceSet related go-client codes
Ⅲ. Does this pull request fix one issue?
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.