Skip to content

Topic recognition #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: topic-recognition
Choose a base branch
from

Conversation

noam-mendelson
Copy link

This pull request contains my implementation of a Convolutional Vision Transformer (CViT) for classification of Alzheimer’s Disease using the ADNI dataset (Task 6). Files included are:
-       dataset.py: data loader for loading and pre-processing data
-       modules.py: source code of the CViT components
-        train.py: source code for training, validating and saving model
-       predict.py: example usage of trained model
-       ./Images: images detailing results of testing, and supporting images for
-       README.md: thorough documentation of project
-       Models.pth: trained model weights saved
 
Thanks,
Noam Mendelson (47432923)

noam-mendelson and others added 24 commits October 13, 2023 19:07
…ttention constructor and transpose_for_scores utility function
…were removed for code simplicity previously)
… image data- reconfigured dataset.py so that it contains data loader for loading and preprocessing (simplified)
…an unrelated brain-dump solution from earlier coursework. Current model training development is being conducted in Colab, and a functional version will be converted from a Jupyter notebook to a .py file
…or CViT. Code migrated code from a Jupyter notebook to a standalone script
…GitHub markdown. MS doc was populated while updating the model for documentation- incomplete
…mit had an empty file, possibly due to sourcing from a different repository
Not relevant- was used for preliminary background context of images
@LinfengLiu98
Copy link
Collaborator

LinfengLiu98 commented Nov 10, 2023

This is an initial inspection, no action is required at this point

Difficulty: Hard

Readme:
Excellent

Commit messages: Excellent, detailed.

Code:

  • Uses Covolutional Vision transformer
  • Well commented
  • Good model design

Functionality/Performance:

  • Val accuracy is 67.8%
  • Don't have train, val and test sets. Only have train and val sets.
  • Did patient-level split
  • Preprocssing data correctly
  • Performed data augmentation
  • Well done

General comments.
Good choice on CViT, should be helpful to deal with small dataset and overfitting problem. Can try more hyperparameter tuning and make the model more smaller. Also seems like your model can be training longer. It's a little bit underfitting just from the training and val loss plot.

@shakes76 shakes76 added the Extension Extension approved label Nov 20, 2023
@shakes76
Copy link
Owner

Marking

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate design and implementation
Good spacing and comments
Header blocks missing -1

Recognition Problem

Solves problem
Driver Script present
File structure present, didnt use own folder and committed to trunk of repo -2
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage, data splits -1
Difficulty: Hard

Commit Log

Meaningful commit messages
Progressive commits used

Documentation

ReadMe acceptable/good
Model/technical explanation
Good Description and Comments
Markdown used and PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
Feedback required, remove model files and move code into own folder as required -2
Request Description good

@shakes76
Copy link
Owner

Can't merge into repo because of large model file, but Feedback marks possible +2 if the requested changes are made (see above).

@shakes76 shakes76 added the question Further information is requested label Nov 20, 2023
@wangzhaomxy
Copy link
Collaborator

No feedback attempt and no feedback marks granted.

@noam-mendelson
Copy link
Author

I am working on feedback- I am currently in hospital so it is difficult for me to do so.

@wangzhaomxy
Copy link
Collaborator

I am working on feedback- I am currently in hospital so it is difficult for me to do so.

I just marked all problem pull requests and was making sure I had covered everyone. You can still get marks after finishing the adjustment. I will get another inspection before the due date. However, we cannot wait for endless time, we have to update your grades to the school in a few days. Please adjust it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extension Extension approved question Further information is requested Transformer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants