Convert to esm #107
Open
Convert to esm #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 19 13 -6
Lines 91 349 +258
Branches 0 41 +41
==========================================
+ Hits 91 349 +258
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0d33cd8 to
8dd7553
Compare
* Prepare build for both CommonJS and ESM support * Export CommonJS bundled as default
This avoids creating another index file
e77d36f to
e75ac16
Compare
nyc doesn't support ESM, but c8 does and is a drop in replacement See https://github.com/bcoe/c8
3640ab9 to
775439f
Compare
Member
Author
|
I published an alpha version using npm info @sinonjs/commons
@sinonjs/[email protected] | BSD-3-Clause | deps: 1 | versions: 25
Simple functions shared among the sinon end user libraries
https://github.com/sinonjs/commons#readme
dist
.tarball: https://registry.npmjs.org/@sinonjs/commons/-/commons-4.0.0-alpha.0.tgz
.shasum: 41fa7570fdc19265981f48ad8520d79703be4ecd
.integrity: sha512-D6UsFb7vj6k/iDBr3TVks/9BHc9vvClRK7JbM3NtxmmV/r2/i/6uh8Z78y4NGMaj2JTRjN2Hy3TTMB5+gPaK5g==
.unpackedSize: 64.0 kB
dependencies:
type-detect: 4.0.8
maintainers:
- mrgnrdrck <[email protected]>
- fatso83 <[email protected]>
- mantoni <[email protected]>
- cjohansen <[email protected]>
- benjamin.gruenbaum <[email protected]>
- simenb <[email protected]>
dist-tags:
latest: 4.0.0-alpha.0
published just now by mrgnrdrck <[email protected]> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first in a series to convert all the Sinon repositories from CommonJS to ESM.
Process:
.cjsextenssion.cjsand.mjsversionsexportsin package.json`nycwithc8, asnycdoesn't (yet) support ESMdist-tagofnext, so we can show that it works in the Sinon dependents before cutting a new release