Skip to content

[action] [PR:18805] Add snmp lldp state check after config_reload #18819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Add SNMP LLDP check after config reload in test cleanup

SNMP LLDP takes a bit longer to be ready after config reload. Ensure that it is ready before proceeding to the next test (snmp/test_snmp_lldp.py).
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

The next test fails because SNMP LLDP is not ready (fails on KeyError because SNMP LLDP entries are not populated properly from snmpwalk).

How did you do it?

Ensure SNMP LLDP is ready after config reload before proceeding to the next test.

How did you verify/test it?

snmp/test_snmp_lldp.py no longer fails when run right after snmp/test_snmp_link_local.py.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

What is the motivation for this PR?
The next test fails because SNMP LLDP is not ready (fails on KeyError because SNMP LLDP entries are not populated properly from snmpwalk).

How did you do it?
Ensure SNMP LLDP is ready after config reload before proceeding to the next test.

How did you verify/test it?
snmp/test_snmp_lldp.py no longer fails when run right after snmp/test_snmp_link_local.py
@mssonicbld
Copy link
Collaborator Author

Original PR: #18805

@mssonicbld
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 158c562 into sonic-net:202411 Jun 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants