Skip to content

Additional DAC Controls #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

relic-se
Copy link

@relic-se relic-se commented Feb 5, 2025

Add the following additional DAC-related controls:

enableDacSoftMute
disableDacSoftMute
enableDacSlowSoftMute
disableDacSlowSoftMute
setDacDeEmphasis
enableDacSlopingStopbandFilter
disableDacSlopingStopbandFilter

Notes:

  • Though the de-emphasis setting is intended for CD audio output, I've found it helpful to clean up the output of Adc signals that have been processed by an MCU and then sent back through the Dac (ie: effects).
  • The soft mute settings successfully remove popping noises when enableDacMute is called.
  • Though, the naming conventions I chose are wordy. Advice on better names for these methods would be appreciated.
  • I haven't noticed a significant effect on the output of the Dac with the sloping stopband filter enabled. The science behind these filters is foreign to me, so I'm not positive exactly what benefits there are to gain with this setting. I'd be happy to remove those functions from this PR if it would be preferred to do so in order to avoid confusion.

@relic-se relic-se changed the title Dac controls Additional DAC Controls Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant