Improved Documentation for Chebyshev.hs and Clarinet.hs. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarinet.hs: type signature on res funtion
anton-k
requested changes
Mar 9, 2017
Contributor
anton-k
left a comment
There was a problem hiding this comment.
Thanks for comments! They can help the novices to grasp the concepts of the library. Would you mind to change the type signatures to more specific ones? So in place of Num a, Fractional t => a -> b -> c I think it would be much better to write the types that we are going to use like D -> D -> Sco (D, D, D). It's better to use Sco in place of Track D
anton-k
approved these changes
Mar 9, 2017
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation comments, type signatures and comments within functions in Chebyshev and Clarinet.