Skip to content

Fix invoking on a nullable exception object in Picasso#deliverAction #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdpqchen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix invoking on a nullable exception object in Picasso#deliverAction #2196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix invoke on nullable exception object
  • Loading branch information
@bdpqchen
bdpqchen committed Jan 31, 2021
commit 5466f5afcc649104f0f65364a48d6dbade8ab410
2 changes: 1 addition & 1 deletion picasso/src/main/java/com/squareup/picasso3/Picasso.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ private void deliverAction(@Nullable Result result, Action action,
log(OWNER_MAIN, VERB_COMPLETED, action.request.logId(), "from " + result.loadedFrom);
}
} else {
Exception exception = checkNotNull(e, "e == null");
Exception exception = (e != null) ? e : new RuntimeException("e == null");
action.error(exception);
if (loggingEnabled) {
log(OWNER_MAIN, VERB_ERRORED, action.request.logId(), exception.getMessage());
Expand Down