Skip to content

Conversation

@F4tal1t
Copy link
Contributor

@F4tal1t F4tal1t commented Dec 8, 2025

As discussed yesterday , i was fixing 130 Typescript linting errors , which I fixed in 1 or 2 hours
most of the errors were caught using npm run lint itself , but after Typescript errors are first caught tsc --noEmit
next it went to ESLint errors.
the errors jumped to 3000 errors (ESLint Errors)

✖ 3070 problems (3013 errors, 57 warnings)
  2937 errors and 0 warnings potentially fixable with the `--fix` option.

npm error Lifecycle script `lint` failed with error:
npm error code 1
npm error path /workspaces/FossFLOW/packages/fossflow-lib
npm error workspace [email protected]
npm error location /workspaces/FossFLOW/packages/fossflow-lib
npm error command failed
npm error command sh -c tsc --noEmit && eslint ./src/**/* --ext .ts,.tsx

Initially it i changed only 6 test files that had Typescript linting errors
now it skyrocketed to 73 files , could be more i havent finished fixing the linting errors

should i continue with this? i will keep this as an draft for now

Cheers,
Dibby

@stan-smith
Copy link
Owner

Hi Dibby, thanks for looking into this. To be honest I'm thinking of moving away from ESlint so hold fire for now :)
Appreciate the work youve done already ❤️

@F4tal1t
Copy link
Contributor Author

F4tal1t commented Dec 8, 2025

2 more things i would ask before closing this PR

  • where did the gcp , kubernetes and aws icons go? were they removed intentionally?
  • thinking of another priority 3 feature , ability to remove labels on icons because sometimes i dont need labels on every icon present inside the diagram , what do you think?

@stan-smith
Copy link
Owner

stan-smith commented Dec 8, 2025 via email

@F4tal1t
Copy link
Contributor Author

F4tal1t commented Dec 8, 2025

i was unaware of this change thanks again!

@F4tal1t F4tal1t closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants