[P0] make sure config only has strs #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

aryamanarora merged 1 commit into stanfordnlp:main from aryamanarora:main

Apr 8, 2024

Collaborator

aryamanarora commented Apr 8, 2024 •

edited

Loading

Description

Stored model type as str in the config dict. Necessary for transformers train loop checks.

Testing Done

Should have no effect on functionality.

Checklist:

My PR title strictly follows the format: [Your Priority] Your Title
I have attached the testing log above
I provide enough comments to my code
I have changed documentations
I have added tests for my changes


          store str in config only

6340a21

aryamanarora requested a review from frankaging

April 8, 2024 22:39

frankaging approved these changes

View reviewed changes

aryamanarora merged commit 957dbdd into stanfordnlp:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet