Skip to content

Change for Linux to builtin printf #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 3.2
Choose a base branch
from
Draft

Change for Linux to builtin printf #2784

wants to merge 1 commit into from

Conversation

drwetter
Copy link
Collaborator

@drwetter drwetter commented May 22, 2025

Describe your changes

This suggested PR changes the order of which printf is being used in choose_printf() so that Linux uses not /usr/bin/printf . This is for some checks slightly faster.

Also PRINTF is now a tunable parameter which can be set through the enviroment like PRINTF=/usr/bin/printf ./testssl.sh <cmdline>

It doesn't / shouldn't solve the bug #2783. But it might help to reproduce it.

What is your pull request about?

  • Bug fix
  • Improvement
  • New feature (adds functionality)
  • Breaking change (bug fix, feature or improvement that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs, indentation is five spaces and any line endings do not contain any blank chars
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix or improvement against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

This suggested PR changes the order of which printf is being used in
`choose_printf()` so that Linux uses not /usr/bin/printf .
This is for some checks slightly faster.

Also PRINTF is now a tunable parameter which can be set through the enviroment
like PRINTF=/usr/bin/printf ./testssl.sh <cmdline>

It doesn't / shouldn't solve the bug #2783. But it might help to reproduce it.
@drwetter drwetter marked this pull request as draft May 23, 2025 09:51
@drwetter
Copy link
Collaborator Author

That should not be merged, see #1130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant