Skip to content

Conversation

@mcnuttandrew
Copy link
Contributor

No description provided.

Copy link
Contributor

@benshope benshope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

/>
</XYPlot>
);
export default class HeatmapChart extends Component {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait until we're able to use hooks instead of making a class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍👍👍👍👍👍👍👍

{x: 3, y: 15, color: 12}
]}
/>
{value && <Hint value={value} />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value !== false if value is a number since it could be zero

@mcnuttandrew mcnuttandrew merged commit 883e78f into uber:master Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants