Skip to content

Conversation

@mcnuttandrew
Copy link
Contributor

No description provided.

@@ -1,5 +1,7 @@
## Hint
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bizzarely there's never been any of our many hint example on this page!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to add one

@@ -1,65 +1,63 @@
import presentation from '../../docs/presentation.md';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was trying to figure out where to put highlight and hexbin and I rage quit trying to mentally diff the whole thing

Copy link
Contributor

@benshope benshope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@@ -1,5 +1,7 @@
## Hint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to add one

"d3-random": "^1.1.0",
"react-virtualized": "^9.18.5",
"react-vis": "^1.9.2"
"react-vis": "^1.11.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I wonder how this got out of date - perhaps bumping this should also be part of a script

@mcnuttandrew mcnuttandrew merged commit f3835e8 into uber:master Sep 24, 2018
ayarcohaila pushed a commit to ayarcohaila/react-vis that referenced this pull request Jun 30, 2021
ayarcohaila added a commit to ayarcohaila/react-vis that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants