Improved feat: add bulk edit mode for request headers #3209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice feature! |
|
love it |
|
What does the bulk editor look like if the header has been unchecked? Also, will support for bulk editing params be implemented as well? |
|
What's left to get this over the finish line? I would like to move to Bruno but lack of bulk header editing has been a blocker for my workflow for some time. Thanks and Happy Holidays! |
This got missed when fixing merge conflicts.
This was referenced May 22, 2025
- Updated QueryParams - Updated RequestHeaders - Reverted VarsTable changes
…ed params are prefixed with `//` now.
naman-bruno
requested changes
Jun 2, 2025
| if (!bulkEdit) { | ||
| setBulkText( | ||
| headers | ||
| .filter((header) => header.enabled) |
There was a problem hiding this comment.
Could you update it to use the // prefix for disabled variables, similar to how it's done for query parameters
| setBulkText( | ||
| headers | ||
| .filter((header) => header.enabled) | ||
| .map((header) => `${header.name}: ${header.value}`) |
There was a problem hiding this comment.
There's also a formatting inconsistency query parameters use the format key:value without a space after the colon, while headers use key: value with a space. It would be good to standardize this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the PR #706, addressing existing conflicts and updating the feature implementation.
Screen.Recording.2024-09-27.at.3.29.28.PM.mov
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.