-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Complete draft spec for customizable <select>
#10548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
josepharhar
wants to merge
179
commits into
whatwg:main
Choose a base branch
from
josepharhar:selectcomplete
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
179 commits
Select commit
Hold shift + click to select a range
088b919
Update content model for customizable select
josepharhar 16fadde
add legend element to optgroup
josepharhar 1330ad5
Relax <select> parser
josepharhar 3c57a19
Update content models for div and span
josepharhar e27ea83
combine select element lines
josepharhar 44225a8
update categories
josepharhar c7deb50
Fix legend and remove note
josepharhar e4d071c
add todo to duplicate table
josepharhar 8e17138
Define base appearance for <select>
josepharhar b87d93d
make rules more permissive
josepharhar 21b8a2c
Define the `<selectedoption>` element
josepharhar 9c72f6c
dont allow hr in option
josepharhar fb7ca7a
remove divs
josepharhar 841e6ff
palpable content except for interactive content
josepharhar c6c208c
replace span with div
josepharhar 0891d73
remove hr from optgroup because parser pr
josepharhar 787e86f
remove images outside options and replace div with span inside option
josepharhar 1aece11
add dl
josepharhar a1bd1e8
index
josepharhar e07cb01
re-add out of select cases
josepharhar 5117d13
re-add reconstruct formatting elements
josepharhar 7a93a56
Add UA stylesheet for <select> base appearance
josepharhar c04ca18
inline replacechildren
josepharhar 09777e2
update content model of button element
josepharhar 33370b7
fix non-select case
josepharhar 76e0d7f
fix variable names
josepharhar 58b9ca9
re-add reconstruct active formatting elements
josepharhar b8ba8e6
remove pop optgroup
josepharhar bfa1c18
remove outdated categories
josepharhar a4954ad
stuff
josepharhar 15f67ea
phrasing content
josepharhar 93ebe9e
improve element lists
josepharhar b6cebc4
make div and span equal again
josepharhar ced6411
Merge branch 'main' into selectcontentmodel
josepharhar c846c3e
add clear a selectedoption
josepharhar bef82d0
nits
josepharhar daabd98
allow no selectedoption
josepharhar bf2b5c5
Merge remote-tracking branch 'upstream/main' into selectedoption
josepharhar 8863966
dont track mutations
josepharhar 17ac232
rename to selectedcontent
josepharhar 4960a77
add parser cloning
josepharhar 57dced1
update phrasing except interactive
josepharhar eb42bf6
remove span from optgroup and select
josepharhar 22b839c
reorder otherwise
josepharhar f40e975
add comment
josepharhar 19c1c04
fix content model for span
josepharhar aa9436e
re-add datalist cases in option content model
josepharhar f8cd659
rewrote a lot
josepharhar 9c41826
Merge branch 'main' into selectrendering
josepharhar 10d1a14
improve things
josepharhar 85b785f
prevent select button from being default submit button
josepharhar c37560a
Always reconstruct formatting context
josepharhar e615f9b
fix hr generate implied end tags
josepharhar 53fa2f4
in reverse tree order
josepharhar 5c0627d
<select><select>
josepharhar 08bdb25
Merge branch 'main' into selectparser
josepharhar eab0bc6
legend element improvements
josepharhar 7f9cc16
remove redundant phrasing content text
josepharhar bed729f
option datalist descendant
josepharhar 1ee134d
only update first inserted selectedoption
josepharhar ec5244b
some nits
josepharhar 9463f7e
improve name of option element ancestor select
josepharhar 02b8cde
more nits
josepharhar e268b44
use post-connection steps
josepharhar 5e5dcb3
Merge branch 'main' into selectrendering
josepharhar 8dc3b0e
reverse tree order
josepharhar 46f457e
code around elements
josepharhar d9bc0b4
nits
josepharhar 72c006b
add open the picker paragraph
josepharhar 2400840
add arrow key events
josepharhar ff59c9d
Merge branch 'main' into selectparser
josepharhar f8d1434
add select to list of end tags which generate implied end tags
josepharhar 5059234
Merge branch 'main' into selectcontentmodel
josepharhar b44ec20
datalist child -> datalist descendant
josepharhar dcf650b
replace activation behavior for options
josepharhar c016a74
Merge branch 'main' into selectedoption
josepharhar f0984d3
Add disabled concept
josepharhar d8a05e5
Make value and selectedIndex setters trigger cloning
josepharhar 9758b7b
Update focus another option
josepharhar 4126c04
Only update first selectedcontent in tree order
josepharhar 42ef681
fix variable names
josepharhar 961fee3
more variable names
josepharhar 999a14a
Remove removal steps
josepharhar 4a175ce
use more <code>
josepharhar 730b52f
Run more updates on insertion and removal
josepharhar d7d7714
ignore the token
josepharhar 3c8e35d
add pageup/pagedown
josepharhar 9991736
Merge branch 'main' into selectcss
josepharhar c6d7d21
update styles to latest resolution
josepharhar ba2d0df
add user-select:none
josepharhar e85aaab
use img alt text in label and text
josepharhar f9654e2
update elements table
josepharhar f3cfbac
update element content categories table
josepharhar e9c98a1
never include img descendants
josepharhar f0aa6ff
add includeAltText check
josepharhar 56a216c
place-items -> align-items
josepharhar 1117978
fix innerText
josepharhar 77d2782
fix rfc keywords and undefined behavior
josepharhar e4e7197
improve optgroup legend labeling
josepharhar b3fbb47
first child -> child
josepharhar 08ce60d
re-add descendants
josepharhar c151264
move more of option picking into algorithm
josepharhar 7a18a77
move more user interaction stuff into algorithms
josepharhar 97af7cd
remove comment
josepharhar 45bbc64
add separate opt in for picker
josepharhar 2449b1f
specfmt wrapping
domfarolino c5b6645
dom feedback
josepharhar 76716d2
improve select.value setter
josepharhar 7668dde
dom comments
josepharhar be8c488
more dom comments
josepharhar 6929058
remove pre-insertion validity
josepharhar 51f0f41
Remove ensure pre-insertion DOM link
domfarolino 6f251fb
fix selectedIndex setter and algorithm declaration
josepharhar 77f9886
remove run these steps
josepharhar 11d436c
Merge branch 'main' into selectparser
josepharhar a2bdcc8
make input close select
josepharhar 5eedddb
Merge branch 'main' into selectcontentmodel
josepharhar 6f1d27c
only use alt text for rendering
josepharhar 9694785
Merge branch 'main' into selectrendering
josepharhar 2ad7144
add aria practices link for keyboard behavior
josepharhar b4cfd59
fix rfc error
josepharhar 9d86011
add select.innerHTML fix
josepharhar 3dfe74c
Improve option list iteration
josepharhar 5282a71
Add check for primary mouse button
josepharhar c04849e
Fix typo in attribute
josepharhar 0310090
address comments
josepharhar f375f1b
remove ", then"
josepharhar 5a0aeac
add <code>
josepharhar 44a7862
remove label attribute prohibition
josepharhar ac87396
Merge branch 'main' into selectcss
josepharhar 9c53509
remove extra newlines
josepharhar d61e87d
update styles
josepharhar d18f554
Drop input inside select.innerHTML assignment
josepharhar 39cc516
remove inherited property
josepharhar e944683
improve fragment case handling
josepharhar 26d3281
use this instead of select
josepharhar 4e758e2
add field-sizing
josepharhar bb763db
update pseudo-elements for native/primitive appearance
josepharhar 8d55bcb
fix typo
josepharhar 4acf5f6
add more base appearance
josepharhar 473ca72
add content model notes
josepharhar 0ea2648
remove extra newline
josepharhar 381d2ec
specfmt
domfarolino 650ca4e
add !important to interactivity
josepharhar 134f651
Run specfmt
domfarolino f6be49e
use stack-pop
josepharhar 3ee8051
remove duplicate >
josepharhar 7f4581e
disallow <div> inside <span>
josepharhar 1a8d313
nits
josepharhar 1a621e1
used named arguments for node cloning algorithm
josepharhar 117ca06
more nits
josepharhar 263c54b
Merge branch 'main' into selectedoption
josepharhar 27ff6b7
fix subtree argument reference
josepharhar b10cd35
Merge branch 'main' into selectcss
josepharhar b609929
Merge branch 'main' into selectparser
josepharhar dd49586
Merge branch 'main' into selectcontentmodel
josepharhar f702568
Merge branch 'main' into selectrendering
josepharhar 9534289
Merge branch 'selectcontentmodel' into selectcomplete
josepharhar 0430604
move option end tag steps out of in select mode
josepharhar 8c70450
Merge branch 'selectedoption' into selectcomplete
josepharhar 5047452
Merge branch 'selectrendering' into selectcomplete
josepharhar e556826
Merge branch 'selectcss' into selectcomplete
josepharhar 5e62c8c
dont use convert nodes into a node
josepharhar 01e1283
use replace all instead of removing all
josepharhar e81a863
Use calc-size() in min sizes
josepharhar bcd9669
add note about label attribute
josepharhar fd109dc
Merge remote-tracking branch 'origin/selectedoption' into selectcomplete
josepharhar 1714324
Merge remote-tracking branch 'origin/selectcss' into selectcomplete
josepharhar 3a3954b
make lists for option element inner contenet elements
josepharhar c62ee82
Merge branch 'selectcontentmodel' into selectcomplete
josepharhar d7d2e9d
dont allow parent select for default submit button
josepharhar 4583a24
make select button inert
josepharhar 0363cf8
remove inert
josepharhar 848d3ad
remove default button logic
josepharhar d9c4f79
Merge branch 'selectrendering' into selectcomplete
josepharhar c85b252
Merge branch 'selectcss' into selectcomplete
josepharhar 0d5cb76
Merge branch 'selectcontentmodel' into selectcomplete
josepharhar 26edf65
make select button not a submit button
josepharhar 823d07a
Merge branch 'selectcontentmodel' into selectcomplete
josepharhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
replace span with div
- Loading branch information
commit c6c208c9e8a4bbee62754beef0f50cf6596b3f22
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.