Cleanup sandbox token lists. #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pointer lock API, popups, and scripts respectively. <ref spec=POINTERLOCK></p> | ||
| pointer lock API, popups, and scripts respectively. <ref spec=POINTERLOCK> <code | ||
| data-x="attr-iframe-sandbox-allow-popups-to-escape-sandbox">allow-popups-to-escape-sandbox</code> | ||
| allows unsandboxed browsing contexts to be created from inside the sandbox.</p> |
There was a problem hiding this comment.
This needs to be done differently. The POINTERLOCK reference needs to be at the end. And you need to use the ";" pattern that is already established. Probably dropping the current "and" and placing it before introducing this last keyword.
|
Also, please drop the period from the commit title. |
955fbaa added the 'allow-popups-to-escape-sandbox' sandbox token, but neglected to update a few lists which ought to have contained it. This patch takes care of those.
|
Thanks! WDYT of the fixup? |
|
Thank you, merged: 36f2a65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
955fbaa added the 'allow-popups-to-escape-sandbox' sandbox token,
but neglected to update a few lists which ought to have contained it. This
patch takes care of those.