Set focused item index to zero if index is nil when updating the delegates #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadymmarkov
approved these changes
Jan 2, 2018
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
==========================================
- Coverage 84.78% 77.15% -7.63%
==========================================
Files 150 150
Lines 10364 10249 -115
==========================================
- Hits 8787 7908 -879
- Misses 1577 2341 +764
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that a user cannot resolve the current item at the index path when the view initially loads because it has yet to receive its initial index. The first component will be returned but if the index is zero you end up without a view.
To fix this, we simply set the index to zero but only if neither the component of item has been set.
This should comply nicely with the focus engine because it searches from the top left corner for the first view to focus.
Note
I bumped the version because I intend to do a minor release as soon as this has been merge into
master.