Re: [PATCH] Windows x64 [repost] - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCH] Windows x64 [repost]
Date
Msg-id [email protected]
Whole thread Raw
In response to Re: [PATCH] Windows x64 [repost]  (Tsutomu Yamada <[email protected]>)
Responses Re: [PATCH] Windows x64 [repost]
List pgsql-hackers
On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada <[email protected]> wrote:
>
> 2) use appropriate macro and datatypes for Windows API.
>   enables more than 32bits shared memory.

Are you sure this one should use __noop, and not __nop?

__noop: http://msdn.microsoft.com/en-us/library/s6btaxcs.aspx
__nop: http://msdn.microsoft.com/en-us/library/aa983381.aspx

I think __nop is what we want?

Also, that turns it into "nop" and not "rep nop", no?

Should we perhaps instead use __yield, per:
http://msdn.microsoft.com/en-us/library/2b2h26kx.aspx


Hopefully someone who knows this better than me can comment :-)

-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: win32 socket definition
Next
From: Magnus Hagander
Date:
Subject: Re: Win64 warnings about size_t